Skip to content

translate-library-colorsys #1084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 4, 2025
Merged

translate-library-colorsys #1084

merged 10 commits into from
Jun 4, 2025

Conversation

alextzioras
Copy link
Contributor

Ποιο issue κλείνει το συγκεκριμένο PR;

Closes #784

Περιγραφή του PR

translation of library/colorsys

@mgiannopoulos24
Copy link
Contributor

Φαίνεται πως δεν υπάρχουν τα παρακάτω στο main.txt λεξικό και για αυτό αποτυγχάνει το pre-commit.

library/colorsys.po:29:Hue
library/colorsys.po:29:Saturation
library/colorsys.po:29:Hue
library/colorsys.po:29:Saturation
library/colorsys.po:29:Q

@alextzioras alextzioras force-pushed the translate-library-colorsys branch from c4791ee to ccc411f Compare May 20, 2025 13:33
skpanagiotis
skpanagiotis requested changes May 21, 2025
View reviewed changes
Copy link
Collaborator

@skpanagiotis skpanagiotis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, only a small suggestion.

@alextzioras @skpanagiotis
Update library/colorsys.po
488710a 
Co-authored-by: Panagiotis Skias <[email protected]>
skpanagiotis
skpanagiotis requested changes May 26, 2025
View reviewed changes
Copy link
Collaborator

@skpanagiotis skpanagiotis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions because basically the text describes what the method does.

Also you should resolve the conflicts.

skpanagiotis
skpanagiotis requested changes May 26, 2025
View reviewed changes
skpanagiotis
skpanagiotis previously approved these changes Jun 4, 2025
View reviewed changes
Copy link
Collaborator

@skpanagiotis skpanagiotis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT 🐍

@skpanagiotis
Copy link
Collaborator

Just add an empty commit because readthedocs process has stuck.

skpanagiotis
skpanagiotis approved these changes Jun 4, 2025
View reviewed changes
Copy link
Collaborator

@skpanagiotis skpanagiotis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤗

@skpanagiotis skpanagiotis merged commit 22857bb into python:3.14 Jun 4, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skpanagiotis skpanagiotis skpanagiotis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[3.14] Translate library/colorsys.po
3 participants
@alextzioras @mgiannopoulos24 @skpanagiotis